Skip to content

build: bump tapd #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: bump tapd #968

wants to merge 1 commit into from

Conversation

GeorgeTsagk
Copy link
Member

Description

This bump is needed in order to test one of the latest features in taproot assets. The LiT itests require loop and since some of the interface signatures changed a version bump and a minimal code change are needed from the side of loop.

Unfortunately this has to wait until the dependent LND & Tapd PRs are merged, in order to update to the final refs

@GeorgeTsagk GeorgeTsagk self-assigned this Jun 23, 2025
@GeorgeTsagk GeorgeTsagk force-pushed the bump-tapd branch 2 times, most recently from b662eb7 to 36468f5 Compare July 30, 2025 10:32
@GeorgeTsagk GeorgeTsagk changed the title (temp)build: bump lnd & tapd build: bump lnd & tapd Jul 30, 2025
@GeorgeTsagk GeorgeTsagk requested a review from bhandras July 30, 2025 10:32
@GeorgeTsagk GeorgeTsagk changed the title build: bump lnd & tapd build: bump tapd Jul 30, 2025
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Comment on lines +844 to +851
// In order to still be compatible with the old wire format for
// asset HTLCs, we populate both fields.
//
// Older versions of tapd will ignore the new field and only use
// the old one.
//
// Newer versions will ignore the old field and only use the new
// field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhandras bhandras requested a review from sputn1ck July 30, 2025 11:25
@bhandras
Copy link
Member

Needs go mod tidy @GeorgeTsagk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants